From 60197a65d9f9a115722864b7aec15f0047b84355 Mon Sep 17 00:00:00 2001 From: blogic Date: Tue, 26 Aug 2008 11:07:04 +0000 Subject: [PATCH] adds more sanity checks to uci firewall git-svn-id: svn://svn.openwrt.org/openwrt/trunk@12392 3c298f89-4303-0410-b956-a3cf2f4a3e73 --- package/firewall/files/uci_firewall.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/package/firewall/files/uci_firewall.sh b/package/firewall/files/uci_firewall.sh index e1c4d4d67..99663c677 100755 --- a/package/firewall/files/uci_firewall.sh +++ b/package/firewall/files/uci_firewall.sh @@ -181,6 +181,8 @@ fw_rule() { [ -n "$dest" ] && TARGET=zone_${dest}_$target || TARGET=$target [ -n "$dest_port" -a -z "$proto" ] && { \ echo "dport may only be used it proto is defined"; return; } + [ -n "$src_port" -a -z "$proto" ] && { \ + echo "sport may only be used it proto is defined"; return; } $IPTABLES -I $ZONE 1 \ ${proto:+-p $proto} \ ${src_ip:+-s $src_ip} \ @@ -225,6 +227,8 @@ fw_redirect() { echo "redirect needs src and dest_ip"; return ; } [ -n "$dest_port" -a -z "$proto" ] && { \ echo "dport may only be used it proto is defined"; return; } + [ -n "$src_port" -a -z "$proto" ] && { \ + echo "sport may only be used it proto is defined"; return; } $IPTABLES -A zone_${src}_prerouting -t nat \ ${proto:+-p $proto} \ ${src_ip:+-s $src_ip} \ -- 2.35.1