From: mentor Date: Mon, 12 Nov 2007 19:20:11 +0000 (+0000) Subject: Revert r2828 - problem appears to be fixed now X-Git-Url: http://git.ozo.com/?a=commitdiff_plain;h=73cbb16ebe4752436ffa9294919c8eb5b83125d9;p=madwifi%2F.git Revert r2828 - problem appears to be fixed now git-svn-id: http://madwifi-project.org/svn/madwifi/trunk@2845 0192ed92-7a03-0410-a25b-9323aeb14dbd --- diff --git a/net80211/ieee80211_node.c b/net80211/ieee80211_node.c index 4ec0dc9..9ad6ae6 100644 --- a/net80211/ieee80211_node.c +++ b/net80211/ieee80211_node.c @@ -738,21 +738,6 @@ static __inline void _node_table_join(struct ieee80211_node_table *nt, struct ie ni->ni_table = nt; tni = ieee80211_ref_node(ni); - /* MT: BEGIN HACK - * XXX: r2792 fixed a bug where ieee80211_ref_node was being - * invoked five times on ni because it was passed to TAILQ_INSERT_TAIL - * which happens to evaluate it's value five times. This fixed a problem - * where we were gaining four extra references, but unfortunately exposed - * other bugs which cause kernel panics. I am working on a fix for this as part - * of ticket #1621. In the meantime, adding these references back is 'wrong' - * but better than getting five new critical defects per day while debugging. - */ - ieee80211_ref_node(ni);ieee80211_ref_node(ni); - ieee80211_ref_node(ni);ieee80211_ref_node(ni); - /* - * END HACK - */ - TAILQ_INSERT_TAIL(&nt->nt_node, tni, ni_list); tni = NULL;